Allow disabling send size zerocopy for rdma #2267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
请问什么情况下需要zero copy，什么情况下不能做zero copy呢？ |
Contributor
Author
|
理论上都应该做zero copy。关闭zery copy主要用来做debug。 |
Contributor
|
ok |
372046933
reviewed
Jun 1, 2023
src/brpc/rdma/rdma_endpoint.cpp
Outdated
| return -1; | ||
| } | ||
| len = from[current]->copy_to(buf, len); | ||
| base::IOBuf tmp; |
Contributor
There was a problem hiding this comment.
use of undeclared identifier 'base'
Tuvie
force-pushed
the
master
branch
3 times, most recently
from
726ee54 to
9f7bce0
Compare
Contributor
|
bazel compile failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed: For convenience of debugging, allow user disabling send size zerocopy with gflags rdma_send_zerocopy
Side effects:
Performance effects(性能影响): If user does not set rdma_send_zerocopy to false, there is no effect for performance
Breaking backward compatibility(向后兼容性):
Check List: