feat(redis): implement Arena::allocate_aligned and apply to RedisReply #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please don't use automatic code formatter, which produce a lot of unrelated code diffs. |
liuhenry946-oss
force-pushed
the
optimize-redis-memory
branch
from
a67ab4b to
338ffbc
Compare
Author
|
@wwbmmm please check it |
liuhenry946-oss
force-pushed
the
optimize-redis-memory
branch
3 times, most recently
from
76fb61b to
0b869c3
Compare
liuhenry946-oss
force-pushed
the
optimize-redis-memory
branch
from
0b869c3 to
6cf32b3
Compare
Author
|
@wwbmmm Could you please approve the workflows? Thanks! |
Member
|
Still lot of unexpected formation related changes, please re-check them, and commit the changes that nessesary only. Git command like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implemented
Arena::allocate_alignedinbutiland applied it to RedisReply to solve the FIXME: "// FIXME(gejun): Call allocate_aligned instead."Changes
butil::Arena.brpc::RedisReplyto use aligned allocation.test/arena_unittest.cpp.