-
Notifications
You must be signed in to change notification settings - Fork 120
remove-environment.properties-note #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
requesting docbuild |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr120 Build Log Output: No log errors found to report. |
I don't see how this is a reason to remove this line. Users need to be attended to adding it, right? How is it impossible that a line is missing from a conf file? (unless we are adding it in automated fashion. Should be in |
|
As I wrote... its impossible for that line to be missing in ACS 4.11+ (tested) as the agent would not connect to mgmt in the first place - so there is no reason to even have this premise that it MIGHT be missing in the first place - it can't be missing. With that logic, we could ask users to check any lines in various files. See my point? |
|
ok, so is this a remark added for trouble shooting? |
|
This was added back in the days of i.e. 4.5 or 4.6, etc, when it was supposed to be added once and it would stay there for the lifetime of that linux box. |
|
ah 👍 than |
The starting premise "if it doesn't exist" is impossible in the first place... (tested on 4.11.0 - agent will never connect if that line is missing in the file) - then no need to the warning/message - so removing it from 4.11+ Upgrade pages.