Skip to content

Conversation

@andrijapanicsb
Copy link
Contributor

The starting premise "if it doesn't exist" is impossible in the first place... (tested on 4.11.0 - agent will never connect if that line is missing in the file) - then no need to the warning/message - so removing it from 4.11+ Upgrade pages.

@andrijapanicsb andrijapanicsb requested a review from nvazquez May 7, 2020 14:28
@andrijapanicsb
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr120

Build Log Output:

No log errors found to report.

@DaanHoogland
Copy link
Contributor

The starting premise "if it doesn't exist" is impossible in the first place... (tested on 4.11.0 - agent will never connect if that line is missing in the file) - then no need to the warning/message - so removing it from 4.11+ Upgrade pages.

I don't see how this is a reason to remove this line. Users need to be attended to adding it, right? How is it impossible that a line is missing from a conf file? (unless we are adding it in automated fashion.

Should

paths.script=/usr/share/cloudstack-common

be in /etc/cloudstack/agent/environment.properties, than i see no reason for this removal.

@andrijapanicsb
Copy link
Contributor Author

As I wrote... its impossible for that line to be missing in ACS 4.11+ (tested) as the agent would not connect to mgmt in the first place - so there is no reason to even have this premise that it MIGHT be missing in the first place - it can't be missing.

With that logic, we could ask users to check any lines in various files. See my point?

@DaanHoogland
Copy link
Contributor

ok, so is this a remark added for trouble shooting?
I see your point but also this was added to help some users (actually to prevent questions). Is that no longer valid or should it maybe be moved to a trouble shooting section instead of deleted?

@andrijapanicsb
Copy link
Contributor Author

This was added back in the days of i.e. 4.5 or 4.6, etc, when it was supposed to be added once and it would stay there for the lifetime of that linux box.
If you have i.e. 4.11 installation, that means either a clean install (line already there) or someone upgraded from earlier version to 4.11 following the docs that say to add that line (line already there/already added).

@DaanHoogland
Copy link
Contributor

ah 👍 than

@andrijapanicsb andrijapanicsb added this to the 4.14.0.0 milestone May 11, 2020
@andrijapanicsb andrijapanicsb merged commit 0382725 into 4.13 May 12, 2020
@andrijapanicsb andrijapanicsb deleted the remove-environment.properties-note branch May 12, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants