Skip to content

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Jun 4, 2020

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.14.0.0 milestone Jun 4, 2020
@yadvr yadvr changed the base branch from master to 4.14 June 4, 2020 01:52
@yadvr
Copy link
Member Author

yadvr commented Jun 4, 2020

request docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr135

Build Log Output:

No log errors found to report.

@NuxRo
Copy link
Contributor

NuxRo commented Jun 4, 2020

The instruction "yum install python36-libvirt" will become unnecessary once we build new rpms with the correct deps, but better mention it than not.

@yadvr
Copy link
Member Author

yadvr commented Jun 4, 2020

The PR is to immediately update the 4.14.0.0 docs website. Yes, if we decide to 4.14.1.0 soon then the explicit command won't be necessary.

Copy link
Contributor

@andrijapanicsb andrijapanicsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: dahn <daan.hoogland@gmail.com>
@yadvr
Copy link
Member Author

yadvr commented Jun 5, 2020

Thanks I'll merge, re-tag and re-publish the docs website.

@yadvr yadvr merged commit fba11da into apache:4.14 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants