Skip to content

Conversation

@davidjumani
Copy link
Contributor

No description provided.

@yadvr
Copy link
Member

yadvr commented Sep 14, 2020

LGTM
@davidjumani can you send the PR with base branch 4.14?

@yadvr
Copy link
Member

yadvr commented Sep 14, 2020

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr152

Build Log Output:

No log errors found to report.

@davidjumani davidjumani changed the title [WIP] Update to java 11 Update to java 11 Sep 18, 2020
@davidjumani davidjumani changed the base branch from master to 4.14 September 18, 2020 09:52
@davidjumani davidjumani marked this pull request as ready for review September 18, 2020 09:52
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. if this is all we need we have certainly improved our docs

@yadvr yadvr modified the milestones: 4.15, 4.14.0.0 Sep 23, 2020
@yadvr yadvr merged commit 17b8ccb into apache:4.14 Sep 23, 2020
yadvr added a commit that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants