Skip to content

Conversation

@onitake
Copy link
Contributor

@onitake onitake commented Jan 11, 2021

Many documents refer to the API documentation by an obsolete link that produces a 404.
This PR replaces all occurences of http://cloudstack.apache.org/docs/api/ with https://cloudstack.apache.org/api.html

Discovered in: #132

@yadvr yadvr changed the base branch from master to 4.15 January 14, 2021 00:34
@yadvr yadvr changed the base branch from 4.15 to master January 14, 2021 00:34
@yadvr
Copy link
Member

yadvr commented Jan 14, 2021

Lgtm can you rebase to 4.15 branch?

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR @onitake.

LGTM

@onitake
Copy link
Contributor Author

onitake commented Jan 15, 2021

@rhtyd Sorry, what do you mean exactly?

  • Rebase on 4.15 and keep the PR as-is (i.e. merge to master)?
  • Rebase on 4.15 and change the merget target to 4.15?
  • Submit a new, separate PR that targets 4.15 and keep this one?

@yadvr
Copy link
Member

yadvr commented Jan 15, 2021

Change base branch of the PR to 4.15 as this needs to go in 4.15

@onitake onitake changed the base branch from master to 4.15 January 15, 2021 16:46
@onitake
Copy link
Contributor Author

onitake commented Jan 15, 2021

@rhtyd Like this?

@yadvr
Copy link
Member

yadvr commented Jan 18, 2021

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr176//

Build Log Output:

No log errors found to report.//

@yadvr yadvr merged commit 20ffa3f into apache:4.15 Jan 18, 2021
@onitake onitake deleted the apilink branch January 18, 2021 18:42
@onitake
Copy link
Contributor Author

onitake commented Jan 18, 2021

@rhtyd Do you need me to resubmit a PR against master, or is this taken care of by the 4.15 commit?

@yadvr
Copy link
Member

yadvr commented Jan 19, 2021

No lgtm @onitake since you've changed base branch to 4.15, I've merged your PR on 4.15 branch and fwd-merge 4.15 to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants