Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Mar 16, 2020

Documentation for CloudStack Kubernetes Service feature
Feature PR: apache/cloudstack#3680

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

requesting docbuild

@andrijapanicsb
Copy link
Contributor

ping @shwstppr do we need more updates, can we get this ready for 4.14?

@andrijapanicsb andrijapanicsb added this to the 4.14.0.0 milestone Apr 12, 2020
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr marked this pull request as ready for review April 13, 2020 09:24
@shwstppr
Copy link
Contributor Author

@andrijapanicsb this is ready for 4.14 and for review
@PaulAngus can you please have a look

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@andrijapanicsb
Copy link
Contributor

@shwstppr is this good for merging?

@apache apache deleted a comment from ACSGitBot May 12, 2020
@apache apache deleted a comment from ACSGitBot May 12, 2020
@apache apache deleted a comment from ACSGitBot May 12, 2020
@apache apache deleted a comment from ACSGitBot May 12, 2020
@apache apache deleted a comment from ACSGitBot May 12, 2020
@apache apache deleted a comment from shwstppr May 12, 2020
@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr91

Build Log Output:

No log errors found to report.

@andrijapanicsb
Copy link
Contributor

Guys, can we get this one in - has anyone reviewed it?
Need it for 4.14 asap

/cc @PaulAngus @rhtyd

@PaulAngus
Copy link
Member

request docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr91

Build Log Output:

No log errors found to report.

@PaulAngus
Copy link
Member

request docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr91

Build Log Output:

No log errors found to report.

@PaulAngus
Copy link
Member

PaulAngus commented May 22, 2020

I've moved some stuff around and made parameter lists more readable (removed horizontal scrolling).

I'm OK with it to go in. @andrijapanicsb

@andrijapanicsb andrijapanicsb merged commit b80aadd into apache:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants