Skip to content

engine/schema: add upgrade path from 4.14.0.0 to 4.14.1.0 #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yadvr merged 1 commit into from
Jan 12, 2021
Merged

engine/schema: add upgrade path from 4.14.0.0 to 4.14.1.0 #4580

yadvr merged 1 commit into from
Jan 12, 2021

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Jan 12, 2021

Description

This PR adds the upgrade path from 4.14.0.0 to 4.14.1.0

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

@davidjumani davidjumani changed the base branch from master to 4.14 January 12, 2021 08:34
@davidjumani davidjumani added this to the 4.14.1.0 milestone Jan 12, 2021
@davidjumani davidjumani requested a review from yadvr January 12, 2021 08:41
@yadvr yadvr marked this pull request as ready for review January 12, 2021 09:33
@yadvr yadvr closed this Jan 12, 2021
@yadvr yadvr reopened this Jan 12, 2021
@yadvr yadvr requested review from Pearl1594 and shwstppr January 12, 2021 09:38
@yadvr
Copy link
Member

yadvr commented Jan 12, 2021

Manually tested, LGTM, adds an empty upgrade path and does nothing else.

@alexandremattioli
Copy link
Contributor

alexandremattioli commented Jan 12, 2021

LGTM

sureshanaparti
sureshanaparti approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Member

yadvr commented Jan 12, 2021

Travis is taking time, I'll merge based on manual testing.

@yadvr yadvr merged commit f70da10 into apache:4.14 Jan 12, 2021
@yadvr
Copy link
Member

yadvr commented Jan 12, 2021

I'll fwd merge and handle rest paths @davidjumani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

No one assigned

Labels

component:database component:upgrade

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidjumani @yadvr @alexandremattioli @sureshanaparti