server: Get vm network/disk statistics and update database per host #4601

ustcweizhou · 2021-01-20T10:11:58Z

Description

This PR fixes an issue when collect vm network or disk statistics from hosts.

If cloudstack fails to get vm statistics from a host, the whole process will be terminated, and it will not get vm statistics from remaining hosts.

With this pr, the host with problem will be ignored, and cloudstack will continue on remaining hosts.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland

small nitpickings 👍

DaanHoogland · 2021-01-21T12:10:53Z

server/src/main/java/com/cloud/server/StatsCollector.java

-                s_logger.warn("Error while collecting vm disk stats from hosts", e);
+                    });
+                } catch (Exception e) {
+                    s_logger.warn("Error while collecting vm disk stats from hosts", e);


we could add host details in this message

server/src/main/java/com/cloud/server/StatsCollector.java

DaanHoogland · 2021-01-21T12:12:21Z

server/src/main/java/com/cloud/server/StatsCollector.java

-                s_logger.warn("Error while collecting vm network stats from hosts", e);
+                    });
+                } catch (Exception e) {
+                    s_logger.warn("Error while collecting vm network stats from hosts", e);


again, we can now add host details to the message

shwstppr · 2021-01-25T10:56:28Z

@ustcweizhou do you plan to address above comments?

@blueorangutan package

blueorangutan · 2021-01-25T11:34:03Z

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2587

weizhouapache · 2021-01-25T14:38:40Z

@DaanHoogland thanks for review. modified some debug message

@shwstppr code is changed.

shwstppr · 2021-01-26T06:03:19Z

@blueorangutan package

blueorangutan · 2021-01-26T06:04:05Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-26T06:29:42Z

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2591

shwstppr · 2021-01-26T06:41:02Z

@blueorangutan test

blueorangutan · 2021-01-26T06:42:01Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-01-26T08:54:57Z

This may require testing on different hypervisors too
@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-01-26T08:56:01Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-01-26T18:09:28Z

Trillian test result (tid-3412)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39607 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4601-t3412-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_07_deploy_kubernetes_ha_cluster	`Failure`	3615.86	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	103.09	test_kubernetes_clusters.py

blueorangutan · 2021-01-26T21:11:04Z

Trillian test result (tid-3414)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42587 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4601-t3414-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	252.62	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	3612.82	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	120.22	test_kubernetes_clusters.py
test_02_create_template_with_checksum_sha1	`Error`	5.11	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	5.11	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	5.10	test_templates.py

DaanHoogland · 2021-02-02T14:07:33Z

3 checksum checks that failed on vmware. not related but very disturbing!?!

DaanHoogland

changes are good, but the contained code is not modularised enough.

shwstppr

LGTM
Tested changes with a KVM env, stats working fine.

ustcweizhou changed the title ~~CLSTACK-3660: Get vm network/disk statistics and update database per host~~ Get vm network/disk statistics and update database per host Jan 20, 2021

ustcweizhou changed the title ~~Get vm network/disk statistics and update database per host~~ server: Get vm network/disk statistics and update database per host Jan 20, 2021

server: Get vm network/disk statistics and update database per host

7a1638e

ustcweizhou force-pushed the 4.14-vm-statistics-per-host branch from 5fb64e1 to 7a1638e Compare January 20, 2021 10:19

DaanHoogland added component:database type:bug type:cleanup type:improvement labels Jan 21, 2021

DaanHoogland added this to the 4.14.1.0 milestone Jan 21, 2021

DaanHoogland approved these changes Jan 21, 2021

View reviewed changes

apache#4601 : modify debug message

c7839e1

apache deleted a comment from blueorangutan Jan 26, 2021

yadvr requested a review from shwstppr January 27, 2021 13:59

ustcweizhou closed this Jan 27, 2021

ustcweizhou reopened this Jan 27, 2021

DaanHoogland approved these changes Feb 2, 2021

View reviewed changes

shwstppr approved these changes Feb 4, 2021

View reviewed changes

yadvr merged commit 4de6ac3 into apache:4.14 Feb 4, 2021

server: Get vm network/disk statistics and update database per host #4601

server: Get vm network/disk statistics and update database per host #4601

Uh oh!

Conversation

ustcweizhou commented Jan 20, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaanHoogland Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jan 25, 2021

Uh oh!

blueorangutan commented Jan 25, 2021

Uh oh!

weizhouapache commented Jan 25, 2021

Uh oh!

shwstppr commented Jan 26, 2021

Uh oh!

blueorangutan commented Jan 26, 2021

Uh oh!

blueorangutan commented Jan 26, 2021

Uh oh!

shwstppr commented Jan 26, 2021

Uh oh!

blueorangutan commented Jan 26, 2021

Uh oh!

yadvr commented Jan 26, 2021

Uh oh!

blueorangutan commented Jan 26, 2021

Uh oh!

blueorangutan commented Jan 26, 2021

Uh oh!

blueorangutan commented Jan 26, 2021

Uh oh!

DaanHoogland commented Feb 2, 2021

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants