Skip to content

Conversation

@andrijapanicsb
Copy link
Contributor

@andrijapanicsb andrijapanicsb commented Feb 4, 2021

Description

"cloud-setup-database" to "cloudstack-setup-databases" in the help section of the script

Types of changes

  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

No need to?

@andrijapanicsb andrijapanicsb added this to the 4.14.1.0 milestone Feb 4, 2021
@shwstppr
Copy link
Contributor

shwstppr commented Feb 5, 2021

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2651

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file is called cloud-setup-databases.in, it is changed from cloud-setup-database to cloudstack-setup-databases, so more cleanup needs to be done. That said this change looks good.

@yadvr yadvr merged commit b8e6c08 into 4.14 Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants