-
Notifications
You must be signed in to change notification settings - Fork 52
RAT-514: WIP Gradle Plugin against 0.17 #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This is an initial draft against the 0.17 release tag as there's no 0.18 branch yet. I've included the HTML template included in #568. The code is very much the same (except for all the things that are not in Java 8). |
|
At least tests pass locally :) |
Claudenw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a method to RatTool public Map<String, GradleOption> gradleOptions() to return a sorted map of CLI option name to GradleOption (see mvnOptions, antOptions, cliOptions).
This will make the options available for documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a section to this pom to generate the site documentaiton.
See rat-plugin initial site generation
The result should generate markdown documentation for this component including a list of options similar to the maven and ant lists.
|
@snazy I'd prefer to have this PR against master ..... before merging it we should clarify the roadmap for an upcoming release. To my mind the architecture discussions will mean a very long development time. @Claudenw Not sure how fast we can transform RAT to become ready for modular clients?! Personally I'd try to avoid having multiple long running branches with contrary concepts being implemented, while downstream clients would prefer faster releases and bugfixes. WDYT? |
Agree. #568 is there for master.
+1 |
No description provided.