Skip to content

RAT-531: Fix NPE on families is null #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
huangxiaopingRD wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RAT-531: Fix NPE on families is null #602

huangxiaopingRD wants to merge 1 commit into from

Conversation

@huangxiaopingRD
Copy link

@huangxiaopingRD huangxiaopingRD commented Dec 29, 2025 •
edited
Loading

RAT-531 Fix NPE on families is null

Caused by: java.lang.NullPointerException: Cannot read the array length because "this.families" is null
    at org.apache.rat.mp.AbstractRatMojo.getConfiguration (AbstractRatMojo.java:508)
    at org.apache.rat.mp.RatCheckMojo.getConfiguration (RatCheckMojo.java:166)
    at org.apache.rat.mp.RatCheckMojo.execute (RatCheckMojo.java:205)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:569)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

ottlinger
ottlinger reviewed Dec 31, 2025
View reviewed changes
apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java
}
if (families != null || getDeprecatedConfigs().findAny().isPresent()) {
if (log.isEnabled(Log.Level.DEBUG)) {
if (log.isEnabled(Log.Level.DEBUG) && families != null) {
Copy link
Contributor

@ottlinger ottlinger Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are running into this NPE due to wrong configuration as the if in line 506 indicates - the families null check is applied but due to the deprecated configuration options this line is entered :)

Copy link
Contributor

@ottlinger ottlinger Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify if you run into other exceptions with that change? I suspect that it only lets you stumble into the next exception .... thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ottlinger ottlinger ottlinger left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huangxiaopingRD @ottlinger