-
Notifications
You must be signed in to change notification settings - Fork 273
docs: Stop generating dynamic docs content in build #3212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Stop generating dynamic docs content in build #3212
Conversation
|
@snmvaughan fyi |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
============================================
+ Coverage 56.12% 60.07% +3.94%
- Complexity 976 1437 +461
============================================
Files 119 172 +53
Lines 11743 15926 +4183
Branches 2251 2631 +380
============================================
+ Hits 6591 9567 +2976
- Misses 4012 5031 +1019
- Partials 1140 1328 +188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit bd46820.
The script was only compiling the spark module, which could miss config changes defined in the common module. Now explicitly compiles both common and spark modules. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Maybe we should use a profile to decide when to generate docs? |
I went with The workflow also has two different targets: during normal publishing, we generate docs into a temp folder (so the repo stays clean), but during the release process, we run |
dev/generate-release-docs.sh
Outdated
| echo "Done! Generated documentation content in docs/source/user-guide/latest/" | ||
| echo "" | ||
| echo "Next steps:" | ||
| echo " git add docs/source/user-guide/latest/configs.md docs/source/user-guide/latest/compatibility.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) We can follow what README.md suggests git add docs/source/user-guide/latest/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
hsiang-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
parthchandra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (please address the comment from @hsiang-c)
Closes #2582
Summary
Move documentation generation from build time to publish time to prevent merge conflicts in PRs.
Previously, GenerateDocs ran during mvn package and modified docs/source/user-guide/latest/configs.md and compatibility.md in-place. When PRs added new configs or expressions, the regenerated tables would conflict with main.
Now:
Changes
How It Works
mainbranch-0.xRelease Process Addition
When cutting a new release:
git checkout -b branch-0.13 main ./dev/generate-release-docs.sh git add docs/source/user-guide/latest/ git commit -m "Generate docs for 0.13.0 release" git push apache branch-0.13Test Plan