feat: ContainerGebConfiguration inheritance #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
matrei
reviewed
Mar 14, 2025
Contributor
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
Cool 😎 !
Is there something preventing this from going into 4.2.x?
spock-container-test-app/src/integration-test/groovy/org/demo/spock/InheritedConfigSpec.groovy
Show resolved
Hide resolved
spock-container-test-app/src/integration-test/groovy/org/demo/spock/InheritedConfigSpec.groovy
Show resolved
Hide resolved
spock-container-test-app/src/integration-test/groovy/org/demo/spock/InheritedConfigSpec.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy
Show resolved
Hide resolved
JonasPammer
force-pushed
the
inheritance
branch
from
4a79a94 to
eccff83
Compare
JonasPammer
force-pushed
the
inheritance
branch
from
eccff83 to
2f39c1f
Compare
JonasPammer
force-pushed
the
inheritance
branch
2 times, most recently
from
f555d9e to
7b9ecd8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
JonasPammer
force-pushed
the
inheritance
branch
from
7b9ecd8 to
6d3a250
Compare
the previous two reverted showcase things were claude lol (only committed as interesting)
JonasPammer
force-pushed
the
inheritance
branch
from
6d3a250 to
9e1a348
Compare
Contributor
Author
|
:) |
matrei
approved these changes
Mar 16, 2025
JonasPammer
commented
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves e.g. #146 (comment)