API: Optimize NOT IN and != predicates for single-value partition manifests #15064
+131
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
reviewed
Jan 19, 2026
| return null; | ||
| } | ||
|
|
||
| if (fieldStats.containsNaN() != null && fieldStats.containsNaN()) { |
Contributor
There was a problem hiding this comment.
containsNaN() is nullable, so null likely means “not recorded/unknown”. Should we treat null as unknown and skip the single-value pruning in that case?
Contributor
Author
There was a problem hiding this comment.
Thank for your your review Huaxin.
You're right, I missed handling the null case. I've updated the code to treat containsNaN() == null as unknown and skip pruning. Also added a test case to verify this behavior.
manuzhang
reviewed
Jan 20, 2026
| return null; | ||
| } | ||
|
|
||
| if (fieldStats.containsNaN() == null || fieldStats.containsNaN()) { |
Member
There was a problem hiding this comment.
I think we can just combine the above two cases (ifs)
Contributor
Author
There was a problem hiding this comment.
Thank you for your review Manu.
You are right, I have combined them into a single condition.
nandorKollar
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds manifest pruning optimization for
NOT INand!=predicates when a manifest contains a single distinct partition value (i.e., whenlower == upper).Problem
Currently, ManifestEvaluator cannot prune manifests for
NOT INand!=predicates, even when the manifest provably contains no matching partitions.Solution
When
lower == upperand the manifest has no nulls or NaNs, we can safely prune if:NOT IN: the single partition value is in the exclusion list!=: the single partition value equals the literalThis mirrors the optimization added in #14593 for InclusiveMetricsEvaluator, but applied at the manifest level for partition pruning.
Testing
notInandnotEqoptimizationsFixes #15063