Skip to content

Conversation

@edgao
Copy link

@edgao edgao commented Jan 20, 2026

similar to ff81344#diff-6c7387be14971c2febd327b91d20ef0e12fc705fc3e7a8449387d8496d418190, except on the glue() method. We're seeing some rate-limit errors when operating against Glue, and the default retry policy (LEGACY, i.e. 3 retries + no backoff) probably isn't helping.

I didn't add a new unit test - that PR adds a test to verify that applyRetryConfigurations works correctly, but that's orthogonal to whether or not the method is actually called. TestAwsClientFactories returns the client object directly, and I couldn't figure out how to easily extract the retry policy from a GlueClient object.

I could be convinced to add this invocation on the dynamo() method as well - LMK

@github-actions github-actions bot added the AWS label Jan 20, 2026
@singhpk234 singhpk234 changed the title set retry policy on glue client AWS: set retry policy on glue client Jan 20, 2026
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, i think dynamo is used both for cases like lockmanager as well as as a catalog so should be fine if we wanna use it

@edgao worst case you can use reflection ? i wonder if we can just test in the way we tested prev ones

@edgao
Copy link
Author

edgao commented Jan 20, 2026

This never was tested, though it probably should be. I'll defer to you on reflection - personally I don't love it (e.g. AWS changes the field name, now our test is broken). But I'll implement it tomorrow and we can see how it looks.

Will add the retry policy on the dynamo client as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants