fix(checkpoint): When loading the replica in the replica_server, the assertion !missing_meta_cf failed

[limowang]

#2215

During rolling upgrades and duplication data migration, there are cases where a replica first learns the checkpoint from the primary replica and then loads the partition. However, if the primary replica crashes during the execution of ::dsn::error_code pegasus_server_impl::copy_checkpoint_to_dir_unsafe(const char *checkpoint_dir, int64_t *checkpoint_decree, bool flush_memtable) while generating the checkpoint, it may skip the final block of code:

std::vector<rocksdb::ColumnFamilyDescriptor> column_families(
    {{DATA_COLUMN_FAMILY_NAME, rocksdb::ColumnFamilyOptions()},
     {META_COLUMN_FAMILY_NAME, rocksdb::ColumnFamilyOptions()}});
status = rocksdb::DB::OpenForReadOnly(
    rocksdb::DBOptions(), checkpoint_dir, column_families, &handles_opened, &snapshot_db);
if (!status.ok()) {
    derror_replica(
        "OpenForReadOnly from {} failed, error = {}", checkpoint_dir, status.ToString());
    snapshot_db = nullptr;
    cleanup(true);
    return ::dsn::ERR_LOCAL_APP_FAILURE;
}
dcheck_eq_replica(handles_opened.size(), 2);
dcheck_eq_replica(handles_opened[1]->GetName(), META_COLUMN_FAMILY_NAME);

As a result, the META_COLUMN_FAMILY_NAME column family might be missing from the checkpoint. When other potential follower replicas request checkpoint data, the primary replica does not validate whether the checkpoint data is complete, which could lead to triggering the !missing_meta_cf assertion failure.

Therefore, after the node crash and restart, the completeness of the checkpoint needs to be verified.

[acelyc111]

use defer to execute cleanup() automatically

[limowang]

Okay, thank you for your advice ！

[empiredan]

Which rules are disabled ? Should also be consistent with build_tools/clang_tidy.py.

[limowang]

The parameter -abseil-string-find-str-contains was added, otherwise the line d1.find("checkpoint") != std::string::npos would not pass the format check (but I didn't modify it).I will synchronize the modification in /build_tools/clang_tidy.py.