Skip to content

Conversation

@empiredan
Copy link
Contributor

@empiredan empiredan commented Dec 23, 2025

#2344.

The internal types used by absl::node_hash_map have different layouts when
compiled with ASan versus non-ASan builds. As a third-party dependency, Abseil
is always built in non-ASan mode. However, when Pegasus is built with ASan enabled,
Abseil headers are also compiled under ASan, which leads to a mismatch between the
header-compiled structures and the Abseil library itself, causing ASAN tests to fail.

Possible solutions include:

  1. When third-party dependencies change, also build those third-party libraries with
    ASan enabled for ASan builds.
  2. When building third-party images, additionally produce a separate ASan-based
    image, which can be used by ASan CI workflows when third-party dependencies
    themselves have not changed.

@empiredan empiredan marked this pull request as ready for review January 5, 2026 08:06
@empiredan empiredan added the type/sanitize Fixes on errors reported by sanitizers. label Jan 5, 2026
@empiredan
Copy link
Contributor Author

Failed tests for Scala client are traced by another issue #2345.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build github scripts thirdparty type/sanitize Fixes on errors reported by sanitizers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant