Skip to content
This repository was archived by the owner on Apr 21, 2023. It is now read-only.

Conversation

@cgiraldo
Copy link

@cgiraldo cgiraldo commented Aug 8, 2017

There are some inconsistencies in the open data model descriptions:

  • There are long and bigint types for timestamps.
  • Ipv4 addresses are declared as long but int is enough.
  • Ipv6 addresses are declared as bigint.
  • http info status are explicitly declared as http_info_status when it is just a specific case of http_code_status.

Here is a modified version of the open data model trying to fix the previous inconsitencies. Following avro types I have used:

  • int for 32bit
  • long for 64bit.
    Avro does not have a type for 128bit. I have use int128 as type definition for the ODM. Avro definition should look like:
    {"type": "fixed", "name": "128bit", "size": 16}

@schonz
Copy link

schonz commented Aug 22, 2018

Hello @cgiraldo
In order to continue, could you please fix your conflicts.
Thank you

@cgiraldo
Copy link
Author

cgiraldo commented Aug 29, 2018

The file I have modified docs/open-data-model/open-data-model.md have been removed from the upstream branch. I opened a new pull request #149 modifying the new file docs/open-data-model.md of the upstream branch.

@cgiraldo cgiraldo closed this Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants