Skip to content

Conversation

@ascheman
Copy link
Contributor

Further align modules and docs with repo manifest

cf. apache/maven-sources#18 and
support-and-care/maven-support-and-care#77

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Run mvn site and examine output in target/site directory.
    Site will also be built on your pull request automatically and attached to GitHub Action result.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

| [Apache Resource Bundles](/apache-resource-bundles/) | [`https://gitbox.apache.org/repos/asf/maven-apache-resources.git`](https://gitbox.apache.org/repos/asf/maven-apache-resources.git) | [GitHub](https://github.com/apache/maven-apache-resources/) | [GitHub Issues](https://github.com/apache/maven-apache-resources/issues) |

#### Shared Components

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In comparison to #786 I'm curious that the whole block got changed. Did you run mvn spotless:apply ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not explicitly, I just did a mvn site which includes a spotless:apply execution.

@hboutemy
Copy link
Member

same feedback as apache/maven-sources#18: too many updates, it's impossible to review, we'll have to split (taking apart the spotless:apply that reformats)

in addition: the issue template in the description makes the interesting parts of the PR completely (= the "why" of the PR) invisible: we'll have to do somthing, because reviewing PRs with that massive boilerplate is a problem (not specific to the intent of this PR, I'm just writing down everything: I'll track that aspect with @slawekjaranowski separately)

@ascheman
Copy link
Contributor Author

Split up to #790, #791, #792, #793, #794, #795, and #796

@ascheman ascheman closed this May 26, 2025
@ascheman ascheman deleted the feature/77-cleanup-repositories branch May 26, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants