-
Notifications
You must be signed in to change notification settings - Fork 9
Implements apache/operserverless#172 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feat: supporting seaweedfs buckets for wsku resources feat: milvus setup may use seaweedfs fix: update valkey image to use bitnamisecure based images
d4rkstar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @francescotimperi !!.
Let me know what you think about my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's ok not to stick to a specific version?
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 30Gi No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francescotimperi :
On most modern CSI drivers / cloud providers (AWS EBS, GCP PD, Azure Disk, etc.) the requests.storage is a reservation and the volume is provisioned with that exact capacity. While in local path it's just a directory (so no reservation..).
We saw that 30Gi is the default size, but it would be good - from your point of view - to make this configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is configurable. the CRD specifies a parameter for it and the operator applies it. By the way the default value it s 60GB.
| containers: | ||
| - name: redis | ||
| image: bitnami/valkey:7.2.5 | ||
| image: bitnamisecure/valkey:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francescotimperi same as above: should we use a specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should but the bitnamisecure repository it is relatively new, and the old bitnami repo has been deprecated. I haven't found a TAG pointing to a specific version yet.
This PR contributes the capability to use SEWEEDFS as an alternative to replace MINIO
feat: added seaweeedfs as MINIO replacement
feat: supporting seaweedfs buckets for wsku resources
feat: milvus setup may use seaweedfs
fix: update valkey image to use bitnamisecure based images
Limitations: The operator does not allow to deploy minio and seaweedfs at the same time. In addition seaweedfs is configured to use volume with a default size of 1GB. The operator sets a default per bucket quota of 1GB, unless otherwise specified and a default size of 60GB for the PVC assigned to the seaweed data folder.