[fix] Remove the pulsar-bom import #22
Conversation
StevenLuMT
force-pushed
the
main-updatePulsarPom
branch
2 times, most recently
from
3e75ce7 to
d6f801a
Compare
…n version, and a unified pulsar version is not strictly necessary. Each project can import it independently. If using the default version, use default.pulsar.version.
StevenLuMT
force-pushed
the
main-updatePulsarPom
branch
from
d6f801a to
695678d
Compare
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Why remove this BOM? Did you encounter any problems?
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Maven dependency management by renaming the pulsar.version property to default.pulsar.version and removing the centralized pulsar-bom dependency management. The changes allow for more explicit version control of Apache Pulsar dependencies across child modules.
- Renamed property
pulsar.versiontodefault.pulsar.versionin parent POM - Removed
pulsar-bomfrom centralized dependency management - Added explicit version declarations for Pulsar dependencies in child modules
- Removed duplicate
pulsar-client-admindependency inpulsar-admin-mcp-contrib
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Renamed pulsar.version property to default.pulsar.version and removed pulsar-bom from dependency management |
| pulsar-transaction-contrib/pom.xml | Added explicit version reference using ${default.pulsar.version} for pulsar-client-all |
| pulsar-rpc-contrib/src/main/resources/pulsar-container.properties | Updated property reference from ${pulsar.version} to ${default.pulsar.version} |
| pulsar-rpc-contrib/pom.xml | Added explicit version references for pulsar-client and pulsar-client-admin dependencies |
| pulsar-client-common-contrib/pom.xml | Added explicit version reference for pulsar-client-all dependency |
| pulsar-admin-mcp-contrib/pom.xml | Added explicit version references and removed duplicate pulsar-client-admin dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <dependency> | ||
| <groupId>org.apache.pulsar</groupId> | ||
| <artifactId>pulsar-client-admin</artifactId> | ||
| <version>${default.pulsar.version}</version> |
There was a problem hiding this comment.
The pulsar-client-admin dependency is missing the <scope>test</scope> that was present in the removed duplicate declaration. If this dependency is only needed for tests, the test scope should be retained on line 42.
| <version>${default.pulsar.version}</version> | |
| <version>${default.pulsar.version}</version> | |
| <scope>test</scope> |
2 participants
Remove the pulsar-bom import; each module is free to use its own version, and a unified pulsar version is not strictly necessary. Each project can import it independently. If using the default version, use default.pulsar.version.