Skip to content

RANGER-5423: Bulk policy evaluation holds read lock for entire batch,… #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vyommani wants to merge 1 commit into
base: master
Choose a base branch
from
+59 −14
Open

RANGER-5423: Bulk policy evaluation holds read lock for entire batch,… #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 59 additions & 14 deletions ...ts-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public class RangerPolicyEngineImpl implements RangerPolicyEngine {
private final PolicyEngine policyEngine;
private final RangerAccessRequestProcessor requestProcessor;
private final ServiceConfig serviceConfig;
private boolean isPolicyEngineMutable;

public RangerPolicyEngineImpl(ServicePolicies servicePolicies, RangerPluginContext pluginContext, RangerRoles roles) {
final boolean isUseReadWriteLock;
Expand All @@ -78,6 +79,7 @@ public RangerPolicyEngineImpl(ServicePolicies servicePolicies, RangerPluginConte
boolean isDeltasSupported = config.getBoolean(pluginContext.getConfig().getPropertyPrefix() + RangerCommonConstants.PLUGIN_CONFIG_SUFFIX_POLICY_DELTA, RangerCommonConstants.PLUGIN_CONFIG_SUFFIX_POLICY_DELTA_DEFAULT);

isUseReadWriteLock = isDeltasSupported && config.getBoolean(pluginContext.getConfig().getPropertyPrefix() + RangerCommonConstants.PLUGIN_CONFIG_SUFFIX_IN_PLACE_POLICY_UPDATES, RangerCommonConstants.PLUGIN_CONFIG_SUFFIX_IN_PLACE_POLICY_UPDATES_DEFAULT);
isPolicyEngineMutable = isUseReadWriteLock;
} else {
isUseReadWriteLock = false;
}
Expand Down Expand Up @@ -249,26 +251,40 @@ public Collection<RangerAccessResult> evaluatePolicies(Collection<RangerAccessRe

Collection<RangerAccessResult> ret = new ArrayList<>();

try (RangerReadWriteLock.RangerLock readLock = policyEngine.getReadLock()) {
if (readLock.isLockingEnabled()) {
LOG.debug("Acquired lock - {}", readLock);
}

if (!isPolicyEngineMutable) {
if (requests != null) {
PolicyEngineSnapshot snapshot;
try (RangerReadWriteLock.RangerLock readLock = policyEngine.getReadLock()) {
if (readLock.isLockingEnabled()) {
LOG.debug("Acquired lock - {}", readLock);
}
snapshot = new PolicyEngineSnapshot(policyEngine);
}
for (RangerAccessRequest request : requests) {
requestProcessor.preProcess(request);

RangerAccessResult result = zoneAwareAccessEvaluationWithNoAudit(request, policyType);

RangerAccessResult result = zoneAwareAccessEvaluationWithNoAudit(request, policyType, snapshot);
ret.add(result);
}
}

if (resultProcessor != null) {
resultProcessor.processResults(ret);
} else {
try (RangerReadWriteLock.RangerLock readLock = policyEngine.getReadLock()) {
if (readLock.isLockingEnabled()) {
LOG.debug("Acquired lock - {}", readLock);
}
if (requests != null) {
for (RangerAccessRequest request : requests) {
requestProcessor.preProcess(request);
RangerAccessResult result = zoneAwareAccessEvaluationWithNoAudit(request, policyType);
ret.add(result);
}
}
}
}

if (resultProcessor != null) {
resultProcessor.processResults(ret);
}

LOG.debug("<== RangerPolicyEngineImpl.evaluatePolicies({}, policyType={}): {}", requests, policyType, ret);

return ret;
Expand Down Expand Up @@ -557,25 +573,29 @@ public RangerAccessRequestProcessor getRequestProcessor() {
}

private RangerAccessResult zoneAwareAccessEvaluationWithNoAudit(RangerAccessRequest request, int policyType) {
return zoneAwareAccessEvaluationWithNoAudit(request, policyType, null);
}

private RangerAccessResult zoneAwareAccessEvaluationWithNoAudit(RangerAccessRequest request, int policyType, PolicyEngineSnapshot snapshot) {
LOG.debug("==> RangerPolicyEngineImpl.zoneAwareAccessEvaluationWithNoAudit({}, policyType={})", request, policyType);

RangerAccessResult ret = null;
RangerPolicyRepository tagPolicyRepository = policyEngine.getTagPolicyRepository();
RangerPolicyRepository tagPolicyRepository = snapshot != null ? snapshot.getTagPolicyRepository() : policyEngine.getTagPolicyRepository();
Set<String> zoneNames = RangerAccessRequestUtil.getResourceZoneNamesFromContext(request.getContext());

LOG.debug("zoneNames:[{}]", zoneNames);

if (CollectionUtils.isEmpty(zoneNames) || (zoneNames.size() > 1 && !request.isAccessTypeAny())) {
// Evaluate default policies
RangerPolicyRepository policyRepository = policyEngine.getRepositoryForZone(null);
RangerPolicyRepository policyRepository = snapshot != null ? snapshot.getRepositoryForZone(null) : policyEngine.getRepositoryForZone(null);

ret = evaluatePoliciesNoAudit(request, policyType, null, policyRepository, tagPolicyRepository);

ret.setZoneName(null);
} else if (zoneNames.size() == 1 || request.isAccessTypeAny()) {
// Evaluate zone specific policies
for (String zoneName : zoneNames) {
RangerPolicyRepository policyRepository = policyEngine.getRepositoryForZone(zoneName);
RangerPolicyRepository policyRepository = snapshot != null ? snapshot.getRepositoryForZone(zoneName) : policyEngine.getRepositoryForZone(zoneName);

ret = evaluatePoliciesNoAudit(request, policyType, zoneName, policyRepository, tagPolicyRepository);

Expand Down Expand Up @@ -1196,4 +1216,29 @@ public boolean isServiceAdmin(String userName) {
return serviceAdmins.contains(userName);
}
}

private static class PolicyEngineSnapshot {
private final RangerPolicyRepository tagPolicyRepository;
private final RangerPolicyRepository policyRepository;
private final Map<String, RangerPolicyRepository> zonePolicyRepositories;

PolicyEngineSnapshot(PolicyEngine policyEngine) {
this.tagPolicyRepository = policyEngine.getTagPolicyRepository();
this.policyRepository = policyEngine.getPolicyRepository();
Map<String, RangerPolicyRepository> zones = policyEngine.getZonePolicyRepositories();
this.zonePolicyRepositories = zones != null ? new HashMap<>(zones) : Collections.emptyMap();
}

public RangerPolicyRepository getTagPolicyRepository() {
return tagPolicyRepository;
}

public RangerPolicyRepository getRepositoryForZone(String zoneName) {
return zoneName == null ? policyRepository : zonePolicyRepositories.get(zoneName);
}

public Map<String, RangerPolicyRepository> getZonePolicyRepositories() {
return zonePolicyRepositories;
}
}
}