RANGER-5330 : Disable tab selection in Ranger UI form fields #774
+78
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the current Ranger UI, when the user focuses on a Select2 field and presses the Tab key, the first value in the dropdown gets automatically selected. This is not the correct behaviour.
The Tab key should only be used for navigation (moving focus between fields) and should not auto-select any value.
Expected Behaviour
Pressing Tab should move the focus to the next input field.
No value should be selected in the Select2 field when Tab is pressed.
Proposed Fix
Remove the tab-based selection behaviour in Ranger UI forms so that Tab is only used for traversal purposes.
How was this patch tested?
Checked that Remove the tab-based selection behaviour in Ranger UI forms so that Tab is only used for traversal purposes.