-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TIR][Schedule]Generalize fuseReductionEpilogue to support arbitrary epilogue expressions #18636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kimm240, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully generalizes the fuseReductionEpilogue primitive by removing the previous pattern-matching logic in favor of a more flexible, expression-based approach. This is a significant improvement that allows for handling arbitrary epilogue expressions. The implementation is well-aligned with the description. I have identified a couple of areas for improvement, mainly related to removing some dead code and simplifying a complex section of the implementation to enhance readability and maintainability. Overall, this is a great enhancement to the framework.
|
@wrongtest-intellif In this PR, I implement general epilogue form. This idea is discussed in #18515. |
wrongtest-intellif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generalized version cover existing testcases. But since it is a "generalized" version, it would be great to add more self-contained checking or comments to prove that the transformation do not accept "false-positive" patterns. It may not be a trivial problem but we could try some improvements.
Refer to https://arxiv.org/html/2510.08726v1, which even leverage symbolic solvers for reduction fusion transformations.
| }; | ||
|
|
||
| // Identity element for reduction (assumed to be 0 for addition-based reductions) | ||
| PrimExpr identity_elem = tir::make_zero(epilogue_output_buffer_->dtype); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, we require epilogue(zero ⊕ x0 ⊕ ... ⊕ xn) == g(xn, g(xn-1, g(.....g(x0, epilogue_init(zero)))...) with g and epilogue_init deduce from epilogue expression, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For BiasAdd, the transformation
However, for non-linear operations like ReLU and Clipping, this identity does not hold if we simply substitute the identity element in the Init block, as
I initially aimed to generalize the logic by processing these operations through a unified substitution mechanism (essentially treating them in a 'per-iteration') to maintain the existing framework's structure-what is merged in #18515.
Should we strictly move these non-linear transformations to the final Store stage (applied once to the final sum)?
Or, since the previous 'per-iteration' behavior was already merged and used, should we keep it as an option or a specific 'fused-update' mode? I'm eager to hear about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correctness matters most. The concrete strategy could be free.
wrongtest-intellif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally look good to me. Please fix lints if you'd like to check in current round of changes. cc @kimm240
e4801de to
cca87cc
Compare
|
@wrongtest-intellif If there are any specific features, improvements, or roadmap items you'd like to see developed in these areas, please let me know. I'd be more than happy to take them on! |
Major Changes for Generalization
1. Pattern Matching Removal
Removed Items:
EpilogueTypeenum (Bias, BiasReLU, Clipping)AnalyzeEpiloguePattern()functionCurrent Approach:
2. Store Entire Epilogue Expression
epilogue_expression_3. Generalized Init Transformation
Examples:
temp + C→0 + C→C(simplify)max(temp + C, 0)→max(0 + C, 0)→max(C, 0)min(max(temp, lower), upper)→min(max(0, lower), upper)4. Generalized Update Transformation
Results and Verification
Existing Tests Pass
All existing tests pass, maintaining backward compatibility:
test_fuse_reduction_epilogue_basictest_fuse_reduction_epilogue_fp32test_fuse_reduction_epilogue_numerical_correctnesstest_fuse_reduction_epilogue_multiple_epiloguetest_matmul_bias_relutest_matmul_bias_relu_correctness_unifiedtest_matmul_clippingtest_matmul_clipping_correctness_unifiedTotal: All 15 tests pass