-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[VULKAN][ADRENO] Vulkan support for Adreno GPU inline with OpenCL #18672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @srkreddy1238, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands TVM's capabilities by integrating a Vulkan backend for Adreno GPUs, aiming to match OpenCL's performance. It introduces a more robust and flexible memory management system that differentiates between buffer and image resources, and refines data transfer operations. The changes also include a new Vulkan-native timer for precise performance measurement and a unified approach to handling OpenCL and Vulkan within the build system and testing framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR is a significant step towards enabling Vulkan support for Adreno GPUs, aligning it with the existing OpenCL backend. The changes are extensive, touching CMake build configurations, the C++ runtime, and Python tests.
Key changes include:
- Centralizing gtest configuration in CMake.
- Major refactoring of the Vulkan runtime to support textures as first-class resources alongside buffers. This introduces
VulkanResource,VulkanImage, andVulkanMemoryclasses for better memory management and abstraction. - Overhauling
CopyDataFromToto handle various resource types (buffer-to-image, etc.). - Adding a Vulkan device timer for accurate profiling.
- Extending Python tests to run on the Vulkan backend for Adreno.
The overall direction is excellent, introducing better structure and abstractions in the Vulkan runtime. The changes are well-thought-out. I have a few minor suggestions for improvement.
bbd5a4e to
0a317b9
Compare
…port This PR enabled Vulkan backend for Adreno GPU along side with OpenCL. With this Adreno GPU can be used with Vulkan backend resulting similar performance line OpenCL. This is foundation to add Vulkan specific extensions in near future like co-op matmul ...etc. Common Relax and TIR pipe line is used here with codegen and runtime being different.
9ee8886 to
1ff94e5
Compare
1ff94e5 to
1c9aa97
Compare
|
Also, addressed the codegen issue due to recent change in |
This PR enabled Vulkan backend for Adreno GPU along side with OpenCL. With this Adreno GPU can be used with Vulkan backend resulting similar performance line OpenCL.
This is foundation to add Vulkan specific extensions of Adreno GPU in near future like co-op matmul ...etc.
Common Relax and TIR pipe line is used for both backends with codegen and runtime being different.
Additionally, this PR defined Vulkan device timer instead of chronos for accurate profiling information.