Skip to content

Conversation

@srkreddy1238
Copy link
Contributor

This allows user defined callback to specify layouts dynamically based on call description.
Helpful to alter layouts based on the operator shapes or attributes.

This allows user defined callback to specify layouts dynamically based on call description
Helpful to alter layouts based on the operator shapes or attributes.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @srkreddy1238, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the ConvertLayout pass within TVM Relax by introducing a mechanism for dynamic layout specification. Instead of relying solely on a predefined map of desired layouts, users can now provide a callback function (layout_cb) that dynamically determines the appropriate layouts for operators based on their call descriptions. This provides greater flexibility, allowing layouts to be adapted on-the-fly according to operator shapes or attributes, which is crucial for optimizing performance in various scenarios.

Highlights

  • Dynamic Layout Specification: Introduced a new LayoutCb type (a ffi::TypedFunction) to allow users to specify layouts dynamically based on call descriptions.
  • Enhanced ConvertLayout Pass: The ConvertLayout pass now accepts an optional layout_cb parameter, enabling dynamic layout determination at runtime.
  • Layout Precedence: If a layout_cb is provided, it will be invoked to determine layouts, overriding any statically defined desired_layouts.
  • Test Coverage: A new test case, test_layout_cb, has been added to demonstrate and verify the functionality of the dynamic layout callback.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for dynamic layout specification through a user-defined callback. The changes look good and are well-tested. I've found a minor typo in a docstring and a small opportunity for code simplification to improve readability and avoid redundant function calls. Overall, this is a solid contribution.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@tlopex tlopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlopex tlopex merged commit d8c973e into apache:main Jan 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants