Skip to content

Conversation

@atticusofsparta
Copy link
Contributor

@atticusofsparta atticusofsparta commented Dec 22, 2025

Summary by CodeRabbit

  • Chores
    • Centralized documentation link management by consolidating hardcoded URLs into a shared constant, ensuring consistent references across the application.

✏️ Tip: You can customize this high-level summary in your review settings.

@atticusofsparta atticusofsparta requested a review from a team as a code owner December 22, 2025 14:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Walkthrough

A new constant ARNS_DOCS_LINK is added to the centralized constants file, replacing hardcoded documentation URLs in two components (DomainsTable and Footer) that now reference this constant instead.

Changes

Cohort / File(s) Summary
Constants Definition
src/utils/constants.ts
Added new exported constant ARNS_DOCS_LINK with value 'https://docs.ar.io/learn/arns'
Component Updates
src/components/data-display/tables/DomainsTable.tsx, src/components/layout/Footer/Footer.tsx
Updated to import and use ARNS_DOCS_LINK constant instead of hardcoded documentation URLs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify the constant value is correct and matches intended documentation URL
  • Confirm both components properly import and reference the constant
  • Check for any other hardcoded instances of this URL that may have been missed

Suggested labels

codex

Poem

🐰 No more URLs scattered 'round,
One constant found where all are bound!
Links consolidated, clean and neat,
DRY principles make refactoring sweet!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(docs): update arns docs link' accurately describes the main change - updating the ARNS documentation link from a hardcoded URL to a centralized constant across multiple components.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-docs-link-arns

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c498c6e and c4160b9.

📒 Files selected for processing (3)
  • src/components/data-display/tables/DomainsTable.tsx
  • src/components/layout/Footer/Footer.tsx
  • src/utils/constants.ts
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-09-10T16:35:55.727Z
Learnt from: dtfiedler
Repo: ar-io/arns-react PR: 873
File: src/components/modals/ant-management/UpgradeDomainsModal/UpgradeDomainsModal.tsx:0-0
Timestamp: 2025-09-10T16:35:55.727Z
Learning: In arns-react, when calling buildDomainInfoQuery (src/hooks/useDomainInfo.tsx), you must pass arioProcessId along with arioContract, domain, aoNetwork, hyperbeamUrl, and antRegistryProcessId; omitting arioProcessId can lead to "No ANT id or record found" and break upgrades.

Applied to files:

  • src/components/data-display/tables/DomainsTable.tsx
📚 Learning: 2025-09-10T16:35:55.727Z
Learnt from: dtfiedler
Repo: ar-io/arns-react PR: 873
File: src/components/modals/ant-management/UpgradeDomainsModal/UpgradeDomainsModal.tsx:0-0
Timestamp: 2025-09-10T16:35:55.727Z
Learning: In arns-react, when calling buildDomainInfoQuery (src/hooks/useDomainInfo.tsx), you must pass arioProcessId along with arioContract, domain, aoNetwork, hyperbeamUrl, and antRegistryProcessId; omitting arioProcessId can lead to “No ANT id or record found” and break upgrades.

Applied to files:

  • src/components/data-display/tables/DomainsTable.tsx
📚 Learning: 2025-12-11T05:20:18.825Z
Learnt from: vilenarios
Repo: ar-io/arns-react PR: 902
File: src/components/modals/turbo/panels/crypto/CryptoConfirmation.tsx:536-540
Timestamp: 2025-12-11T05:20:18.825Z
Learning: Guideline: For tokens on Base network that use 6 decimals (e.g., base-ario ERC-20), convert amount to smallest units using a 1e6 multiplier. Use Math.round(amount * 1e6) when computing the on-chain value. Do not assume 18 decimals. Apply this conversion consistently in code paths that perform payments in CryptoConfirmation.tsx or similar components, and document that the base-ario/USDC-like tokens use 6 decimals to avoid mispricing or transfer errors.

Applied to files:

  • src/components/data-display/tables/DomainsTable.tsx
  • src/components/layout/Footer/Footer.tsx
🧬 Code graph analysis (2)
src/components/data-display/tables/DomainsTable.tsx (1)
src/utils/constants.ts (1)
  • ARNS_DOCS_LINK (344-344)
src/components/layout/Footer/Footer.tsx (1)
src/utils/constants.ts (1)
  • ARNS_DOCS_LINK (344-344)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: deploy-preview
  • GitHub Check: lint_test_build
🔇 Additional comments (5)
src/components/data-display/tables/DomainsTable.tsx (2)

37-37: LGTM! Proper import of the centralized constant.

The import follows the existing pattern in the file and correctly brings in the new ARNS_DOCS_LINK constant.


425-425: LGTM! Clean usage of the centralized documentation link.

The constant is correctly used in the "Learn more about Under_names" link within the undernames tooltip. This ensures consistency across the application and makes future URL updates easier.

src/components/layout/Footer/Footer.tsx (2)

10-10: LGTM! Proper import of the centralized constant.

The import correctly adds ARNS_DOCS_LINK alongside the existing ARIO_DISCORD_LINK import, following the established pattern.


101-101: LGTM! Clean usage of the centralized documentation link.

The constant is correctly used in the Documentation button's click handler in the footer. This ensures the documentation link is consistent across all components and simplifies future maintenance.

src/utils/constants.ts (1)

344-345: LGTM! Clean centralization of the documentation link.

The URL points to the correct Arweave Name System (ArNS) documentation, which covers the censorship-resistant naming system powered by ARIO tokens and enabled through AR.IO gateway domains. The constant follows established naming conventions and improves maintainability by centralizing the documentation reference in one location. Future URL updates only require a single change.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Permaweb Preview Deployed

Your preview is available at: https://pr-907_arns.arweave.net

Property Value
Transaction ID JF2_m5RJjP6I1TzE1Wfr_7WbaqaDHxNHKX61ig4XWrI
ArNS Name arns
Undername pr-907

This preview will be available permanently on Arweave.

@atticusofsparta atticusofsparta merged commit 7b6da5b into develop Dec 22, 2025
4 checks passed
@atticusofsparta atticusofsparta deleted the fix-docs-link-arns branch December 22, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants