-
Notifications
You must be signed in to change notification settings - Fork 15
Implement Cross-Polarization Antenna Factors #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlanSalcedo
wants to merge
23
commits into
master
Choose a base branch
from
crosspol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying all instances
…actors_Tdomain*_new everywhere and drop the old function afterward
…I'll drop the new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces cross-polarization (cross-pol) support in the antenna factor calculations. The modifications ensure that both co-pol and cross-pol effective heights, gains, and phases are applied in the simulation framework for all types of events (neutrinos, pulsers, etc).
Key Changes:
Note: I tried to keep changes minimal. The only repeated work is having to calculate cross-pol effects in each event type. This repetition of event types is fixed -I believe- in the ongoing multitriggers branch, so I will not pursue it now.
Also, the overall amplitudes of the pulsers will be discussed on the reco/sources call on Dec. 12, 2024. It's a matter of modifying a coefficient.
Usage:
Just add CROSSPOL_RX=1 and/or CROSSPOL_TX=1 to your setup file. They are set to 0 by default to return to the nominal state of the code. Only EVENT_TYPE=12 (REAL PULSER SIMS) requires CROSSPOL_TX=1.
Supporting plots:
Here are the signal-only waveforms for a simple pulser simulation (EVENT_TYPE=11). A simple pulser considers a pulse not emitted by a transmitting antenna (no anttena amplification during transmission):
The order of the images is:
(1) No x-pol
(2) Yes Tx x-pol
(3) Yes Rx x-pol
(4) Yes Tx and Rx x-pol
Because there's no Tx response, we expect (1) = (2), (3)=(4), and x-pol Rx showing in both (3) and (4).
Here are the signal-only waveforms for a real pulser simulation (EVENT_TYPE=12)
The order of the images is:
(1) No x-pol
(2) Yes Rx x-pol
(3) Yes Tx x-pol
(4) Yes Rx and Tx x-pol
We expect (2) to show something on Hpols, (3) to also show something on Hpols but different than (2), and (4) to show the linear addition of the voltages.
More documentation later this week. For now:
I made sure to consider the amplitude after Tx to be that of a vector (because it's an electric field) so the amplitude is sqrt(E_tx_xpol^2 + E_tx_copol^2). At the receiver, the voltages add linearly because we're adding the components of the electric field projected onto their effective heights.