Skip to content

Conversation

@wesinator
Copy link

Thanks for the work on this extension.

This PR adds a check to properly handle the case where the current page view is a reader mode (in Firefox), sending the actual raw URL to resurrect pages.

Enter about:reader?url=https%3A%2F%2Fwww.howtogeek.com%2F352267%2Fhow-to-use-the-reader-view-in-firefox%2F in browser and the resurrect pages from the toolbar links.

@arantius
Copy link
Owner

arantius commented Jul 2, 2021

Thanks for the PR. But:

  1. It's got syntax errors (missing closing paren, decodeURIcomponent is not defined).
  2. Coding style doesn't match (indent by two, braces around blocks aren't optional, single quotes around strings)
  3. Even if that's fixed, it functions only from the context menu -- the toolbar button behavior is now inconsistent.

(edit: markdown syntax)

@wesinator
Copy link
Author

@arantius happy new year,

This change is now fixed, tested and works correctly

@wesinator wesinator changed the title properly open urls from firefox reader mode page properly handle edge cases on page/tab URLs Jun 8, 2025
url processing in common for page funcs

close arantius#52
@wesinator
Copy link
Author

wesinator commented Jun 8, 2025

I updated this to handle #52, and move the url scheme processing to common, where it gets called both in the popup script and the background script for page URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants