-
Notifications
You must be signed in to change notification settings - Fork 27
properly handle edge cases on page/tab URLs #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wesinator
wants to merge
10
commits into
arantius:master
Choose a base branch
from
wesinator:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR. But:
(edit: markdown syntax) |
Author
|
@arantius happy new year, This change is now fixed, tested and works correctly |
url processing in common for page funcs close arantius#52
Author
|
I updated this to handle #52, and move the url scheme processing to common, where it gets called both in the popup script and the background script for page URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the work on this extension.
This PR adds a check to properly handle the case where the current page view is a reader mode (in Firefox), sending the actual raw URL to resurrect pages.
Enter
about:reader?url=https%3A%2F%2Fwww.howtogeek.com%2F352267%2Fhow-to-use-the-reader-view-in-firefox%2Fin browser and the resurrect pages from the toolbar links.