Implement Wire.end() for SAM core #3894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Mhhh, why OUTPUT? I'm expecting to see them set as INPUT
Contributor
Author
There was a problem hiding this comment.
@cmaglie upon further investigation, this code isn't needed, as the PIO_Configure calls in the Wire1_Init do not enable pull ups. I've updated this in: sandeepmistry@dd7e908
I was confused my the external SDA0 and SCL0 pull ups on the Due.
cmaglie
added
Library: Wire
sandeepmistry
added
the
Architecture: SAM
also moved common reset and disable code in libsam TWI_ConfigureMaster and TWI_ConfigureSlave functions to new TWI_Disable function, which is used in TwoWire::end()
The Due has external pull-ups on the SDA0 and SCL0, and PIO_Configure in Wire*_Init does not enable then.
sandeepmistry
force-pushed
the
sam-Wire.end-2
branch
from
dd7e908 to
851efae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the SAM side of #613.
Also moved common reset and disable code in libsam
TWI_ConfigureMasterandTWI_ConfigureSlavefunctions to newTWI_Disablefunction, which is used inTwoWire::end()The
TwoWireconstructor now has a new end callback parameter that is used to undo any actions that were done in the begin callback.Updated version of #3730