Skip to content

Conversation

@mmilkin
Copy link

@mmilkin mmilkin commented Mar 30, 2014

What

Using gmusicapi Jukebox now supports the use of GoogleMusic accounts.

Adding a new GooglePlayStorage('username', 'password')

What is still to do:
Add MultipleStorage to access multiple users accounts as well as local accounts.
Have a smarter Authentication layer when the session expires.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making all kinds of blocking calls in the event loop.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figured it was ok cause its basicly in init but probably needs to be defferd to thread

@mmilkin
Copy link
Author

mmilkin commented Nov 11, 2014

Made some changes still need to fix tests and add get_uri that returns a differed but a good start .

jukebox/song.py Outdated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the bad.

@mmilkin
Copy link
Author

mmilkin commented Nov 11, 2014

Now with less blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants