Skip to content

Conversation

@parallels999
Copy link

$("input[type=button1]").click(function () {
    $("#wrapper tr").prettyTextDiff({
        cleanup: $("#cleanup").is(":checked"),
        diffContainer: false, //setting false or null
        debug:true,
    });
});

Example: https://jsfiddle.net/rym8c2f0/
image

@arnab
Copy link
Owner

arnab commented Oct 1, 2024

Hi @parallels999 - thanks for the change. Couple of requests:

  1. What is the need, pros and cons of setting diffContainer: false? I no longer use this library, so I am curious.

  2. Please follow the steps listed in https://github.com/arnab/jQuery.PrettyTextDiff?tab=readme-ov-file#development. Specifically, use the cake build command to produce the change in JS minified version of the code. And then increment the version in package.json (I think 1.1.0 would be apt, unless this is a backward incompatible change).

@parallels999
Copy link
Author

What is the need, pros and cons of setting diffContainer: false?

The idea is not to have a third container with the changes, but to show old/new in the same existing containers

Specifically, use the cake build

i have no idea how to do it, I thought there would be a github action that took care of that in the releases

@arnab
Copy link
Owner

arnab commented Oct 2, 2024

Specifically, use the cake build

i have no idea how to do it, I thought there would be a github action that took care of that in the releases

I totally understand. This library was written 12 years ago, when:

  1. there were no Github actions :)
  2. Coffeescript was cool and hip

In any case, the instructions to install cake are right in the same notes: https://github.com/arnab/jQuery.PrettyTextDiff?tab=readme-ov-file#development (it's just a npm package).

@arnab arnab mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants