Skip to content

Conversation

@mizaki
Copy link
Contributor

@mizaki mizaki commented Dec 16, 2014

This is a quick knock up of the idea to make player comments easier to read. I'm not sure where you would like the function put (guessing not in the display function?). I also had to replace jquery-ui to add the tab function (I just added everything for my ease).

Thoughts?

@arnecls
Copy link
Owner

arnecls commented Dec 16, 2014

First: Thanks for the pull request.
As far as I can see (I'm currently at work and can only see the source) you add all comments to the raid comment field, right?
I guess a better place for this would be the upcoming log tab, so I would "merge" this when I start this feature, i.e. I would integrate the same functionality into the log tab.

@mizaki
Copy link
Contributor Author

mizaki commented Dec 16, 2014

Sounds good. I was wondering about the logging myself but started small. All it does is make three tabs in the raid comment div: Raid, Player and Cancelled, with a count for the player notes.

It kind of drives me crazy clicking notes atm because the double click picking/unpicking is not a double click event. Click on one comment and then click another and you've picked/unpicked someone. :)

@mroswald
Copy link
Contributor

you can see a simple comment function in my latest commit in a fork:
mroswald/raidplaner@b70308c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants