chore(EMI-3018): consolidate checkout error modals and remove unstated #16521
+152
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdstock
commented
Dec 22, 2025
Comment on lines
5
to
11
| export enum CheckoutModalError { | ||
| LOADING_TIMEOUT = "loading_timeout", | ||
| ARTWORK_VERSION_MISMATCH = "artwork_version_mismatch", | ||
| ARTWORK_NOT_FOR_SALE = "artwork_not_for_sale", | ||
| SUBMIT_ERROR = "submit_error", | ||
| UNHANDLED = "UNHANDLED", | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Unhandled was intended as a fallback but it isn't necessary yet.
erikdstock
force-pushed
the
erik.chore-consolidate-checkout-modals
branch
from
bf33fb3 to
deabca3
Compare
#5737 Bundle Size — 9.53MiB (+0.07%).d61cc70(current) vs 9d5b88f main#5729(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Bundle metrics
|
| Current #5737 |
Baseline #5729 |
|
|---|---|---|
 Initial JS |
3.7MiB(~-0.01%) |
3.7MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
47.06% |
37.44% |
| Chunks |
102 |
102 |
| Assets |
105 |
105 |
| Modules |
5958(+0.25%) |
5943 |
 Duplicate Modules |
601(+2.21%) |
588 |
| Duplicate Code |
4.49%(+1.13%) |
4.44% |
| Packages |
297 |
297 |
| Duplicate Packages |
33 |
33 |
Bundle size by type 2 changes 1 regression 1 improvement
| Current #5737 |
Baseline #5729 |
|
|---|---|---|
| JS |
9.39MiB (+0.07%) |
9.38MiB |
| Other |
144.17KiB (-0.07%) |
144.28KiB |
Bundle analysis report Branch erik.chore-consolidate-checkout-... Project dashboard
Generated by RelativeCI Documentation Report issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: chore
This PR relates to EMI-3018
Description
This PR removes our usage of
unstatedwithinjectDialog()to put all error modals in one place. There are still confirmation dialogs associated with deleting saved addresses.This does not complete the linked ticket because we cannot remove
unstateduntil the legacy checkout is fully retired.