Skip to content

Conversation

@masaoliou
Copy link

No description provided.

masaoliou and others added 3 commits May 16, 2023 17:55
modified:   cppdb/frontend.h
new file:   cppdb/postgres_backend.h
modified:   drivers/postgres_backend.cpp
modified:   src/frontend.cpp
modified:   test/dummy_driver.h
@dreaming-augustin
Copy link
Collaborator

Thank you!

I will arrange some time to review the patch and see what I can do on the MySQL side.

The first thing I notice is that the following comments should be removed everywhere:
// Added by CN.

@dreaming-augustin
Copy link
Collaborator

@masaoliou
First, I am certain that you are much more competent and experienced than I am, so thank you for your understanding and patience with me. ;) I am here not because of my skills but simply because I volunteered.

If I understand correctly, your branch contains two major changes:
1- Add bool type,
2- enable PostgreSQL connection to listen on NOTIFY
The first one I understand easily, the second one I am not sure.

Is there a particular reason why you moved everything in drivers/postgres_backend.cpp to cppdb/postgres_backend.h?

We can get a better view of the changes made with the following command (adjust according to your local remotes layout):
$ git diff :drivers/postgres_backend.cpp masaoliou/master:cppdb/postgres_backend.h

@dreaming-augustin dreaming-augustin marked this pull request as draft May 23, 2023 05:21
@dreaming-augustin
Copy link
Collaborator

The pull request is uncommitable as it is.
Implementations for all drivers are missing.

I am trying to have a go at implementing the bool type.
So far there is only the interface; the actual implementation is missing:
https://github.com/artyom-beilis/cppdb/tree/bool-type

@dreaming-augustin dreaming-augustin changed the title Add bool type, enable PostgreSQL connection to listen on NOTIFY Add bool type Jun 11, 2023
@masaoliou
Copy link
Author

The pull request is uncommitable as it is. Implementations for all drivers are missing.

This fork supports only PostgreSQL. g++10.2.1 compiles.
All other drivers are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants