Fix verbose: true not sending when only flowId is present
#289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the embedded sign-in and sign-up flows in the
@asgardeo/javascriptpackage to improve payload handling. The main change is to ensure theverboseparameter is only added internally and conditionally, making the API usage cleaner and more predictable.Embedded flow payload handling improvements:
executeEmbeddedSignInFlowV2andexecuteEmbeddedSignUpFlowV2now strip out any user-suppliedverboseparameter from the payload to prevent external control over this internal flag. (packages/javascript/src/api/v2/executeEmbeddedSignInFlowV2.ts, [1];packages/javascript/src/api/v2/executeEmbeddedSignUpFlowV2.ts, [2]verbose: trueparameter is now conditionally added only when the payload contains either justapplicationIdandflowType, or justflowId. This ensures that themetafield is included in the response only when necessary. (packages/javascript/src/api/v2/executeEmbeddedSignInFlowV2.ts, [1];packages/javascript/src/api/v2/executeEmbeddedSignUpFlowV2.ts, [2]Documentation:
.changeset/hungry-ties-bet.md, .changeset/hungry-ties-bet.mdR1-R6)Related Issues
asgardeo/thunderruntime #212Related PRs
Checklist
Security checks