Skip to content

Conversation

@brionmario
Copy link
Member

Purpose

This pull request refactors the embedded sign-in and sign-up flows in the @asgardeo/javascript package to improve payload handling. The main change is to ensure the verbose parameter is only added internally and conditionally, making the API usage cleaner and more predictable.

Embedded flow payload handling improvements:

  • Both executeEmbeddedSignInFlowV2 and executeEmbeddedSignUpFlowV2 now strip out any user-supplied verbose parameter from the payload to prevent external control over this internal flag. (packages/javascript/src/api/v2/executeEmbeddedSignInFlowV2.ts, [1]; packages/javascript/src/api/v2/executeEmbeddedSignUpFlowV2.ts, [2]
  • The verbose: true parameter is now conditionally added only when the payload contains either just applicationId and flowType, or just flowId. This ensures that the meta field is included in the response only when necessary. (packages/javascript/src/api/v2/executeEmbeddedSignInFlowV2.ts, [1]; packages/javascript/src/api/v2/executeEmbeddedSignUpFlowV2.ts, [2]

Documentation:

Related Issues

Related PRs

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

…g 'verbose' parameter and conditionally add 'verbose: true' based on payload structure.
@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 1bac245 into asgardeo:main Dec 17, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants