Skip to content

Conversation

@brionmario
Copy link
Member

Purpose

This pull request addresses a social button rendering issue in v2 and introduces several improvements to the embedded authentication flow, including support for a divider component, enhanced internationalization, and more robust handling of social login buttons. The changes also improve code clarity and maintainability by refining type definitions and component logic.

Authentication Flow Enhancements:

  • Added support for a new Divider component type (EmbeddedFlowComponentType.Divider) for visual separation within authentication flows, and updated the component factory to render this divider appropriately. [1] [2]
  • Improved handling of social login buttons: detection now considers the button variant, allowing more accurate rendering of branded social buttons (Google, GitHub, Facebook, Microsoft, LinkedIn, Ethereum) even when the button text or variant changes. [1] [2] [3]

Internationalization (i18n) Improvements:

  • Added a new translation key 'elements.display.divider.or_separator' to the i18n model and provided translations for all supported languages (English, French, Hindi, Japanese, Portuguese (Brazil and Portugal), Sinhala, Tamil, Telugu). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Type and API Refinements:

  • Expanded and improved documentation for enums in embedded-flow-v2.ts, including EmbeddedFlowComponentType, EmbeddedFlowActionVariant, EmbeddedFlowTextVariant, and EmbeddedFlowEventType, making the API clearer and easier to use. [1] [2] [3] [4]
  • Updated function signatures throughout the React component factory and sign-in/sign-up flows to allow skipping validation for certain actions (e.g., social logins or triggers), providing a more flexible and robust form handling experience. [1] [2] [3] [4] [5]

Bug Fixes:

Component Structure Improvements:

  • Updated the rendering of block components to wrap their children in a <form> element, improving semantic structure and accessibility.
Screenshot 2025-12-19 at 14 26 55

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@brionmario brionmario force-pushed the refactor-thunder-flows branch from e569139 to 02f3343 Compare December 19, 2025 08:58
@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit d938672 into asgardeo:main Dec 19, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants