fix: re-evaluate function calls in until loop conditions #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Re-evaluate Function Calls in Until Loop Conditions
Problem
In goboscript, when a function call (e.g., random(1, 10)) is used in the condition of an until loop, the function was only evaluated once at the start of the loop. This meant that the loop would not re-evaluate the condition on each iteration, leading to unexpected behavior.
Solution
We modified the code generation logic for the until loop in src/codegen/stmt.rs to duplicate the condition evaluation code at the end of the loop body. This ensures that the condition (and any function calls within it) is re-evaluated on each iteration, matching the expected behavior in Scratch.
Testing
A test case was added in playground/stage.gs that uses an until loop with a random(1, 10) function call in its condition. The test verifies that the loop continues until the random function returns 5, and the count is incremented and displayed on each iteration.
Impact
This fix ensures that goboscript's until loop behaves correctly, making it more reliable for projects that rely on dynamic conditions within loops.