Use std::optional for ET feeder node attributes and introduce INVALID_COMM_TYPE in protobuf
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoongunPark
reviewed
Feb 4, 2025
| this->is_cpu_op_ = static_cast<bool>(attr.bool_val()); | ||
| } else if (attr_name == "num_ops") { | ||
| this->num_ops_ = static_cast<uint64_t>(attr.int64_val()); | ||
| } else if (attr_name == "tensor_loc_") { |
Collaborator
There was a problem hiding this comment.
QQ: is the attribute name "tensor_loc_" not "tensor_loc"?
What upstream tool uses that name? STG?
I think Chakra converter does not use that attribute name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the handling of optional attributes for ET feeder nodes. Previously, default values for fields like
num_opsandtensor_sizewere uninitialized, potentially returning random values. The changes:CollectiveCommTypeenum to represent a default communication type.These updates improve the robustness of the code by preventing uninitialized data from being returned.