Skip to content

refactor: fix SonarCloud issues in autocomplete setup #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarshanCode2005 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: fix SonarCloud issues in autocomplete setup #1971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions scripts/enableAutoComplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* eslint-disable @typescript-eslint/no-var-requires */
const { spawnSync } = require('child_process');
const os = require('os');
const fs = require('fs');
const path = require('path');
const { spawnSync } = require('node:child_process');
const os = require('node:os');
const fs = require('node:fs');
const path = require('node:path');

const allowedShells = ['zsh', 'bash'];
const allowedShells = new Set(['zsh', 'bash']);

// Helper function to find the first existing file among a list of paths
function findExistingFile(possibleFiles) {
Expand Down Expand Up @@ -58,7 +58,7 @@ if (shellConfigs.bash.detectFile) {
}

function getShellConfig(shell) {
if (!allowedShells.includes(shell)) {
if (!allowedShells.has(shell)) {
throw new Error(`Unsupported shell: ${shell}. Autocomplete only supports zsh and bash.`);
}
return shellConfigs[shell];
Expand Down Expand Up @@ -133,7 +133,7 @@ function generateAutocompleteScript(shell) {
}

function setupAutocomplete(shell) {
if (!allowedShells.includes(shell)) {
if (!allowedShells.has(shell)) {
console.error(`❌ Autocomplete only supports zsh and bash. Skipping setup for ${shell}.`);
return;
}
Expand Down
Loading