Remove plugs #69
Open
Remove plugs #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
kelvinst
suggested changes
Sep 16, 2019
Contributor
kelvinst
left a comment
kelvinst
left a comment
There was a problem hiding this comment.
Just remember to remove the references to plugs on README. Maybe mentioning that that now they're on triplex_plugs lib.
Contributor
|
Also, once we merge #60, we must remove that one from here and move it there. |
Contributor
Author
yes! I will work to improve the docs too. |
Contributor
|
@mgiacomini were you able to work on it? If not, can we send the task to someone else? I can take over if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the #63, this pull request remove all plugs in favor of a new lib.