Phasechange #2
Open
Phasechange #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding cylindrical coordinates to the restart of a simulation.
m_phase_change: removing m_palpha_eps and ptgalpha_eps from global parameters, and adding it to user-input level m_start_up: adding palpha_eps and ptgalpha_eps to the startup dictionary m_global_parametes: setting palpha_eps and ptgalpha_eps as default and setting theis default values. m_mpi_proxy: broadcasting palpha_eps and ptgalpha_eps
Changes in both pT-equilibrium and pTg-equilibrium. Note that, while the pT-equilibrium algorithm is globally convergent given the physical constraints are satisfied, this is yet not true for the pTg-equilibrium. Currently debugging the case in which there is a pressure jump.
- Merging pT- and pTg-equilibrium into just one infinite fast equilibrium subroutine. - Cleaning PRINT statements. - Removing unecessary calculations - Adding stronger statements to the phase-change crieteria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.