Skip to content

Merge master into production #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinBol merged 3 commits into from
Dec 11, 2025
Merged

Merge master into production #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53a3899
Update release.yml
RobinBol Oct 20, 2022
4afec95
Merge pull request #27 from athombv/production
RobinBol Dec 11, 2025
f33a167
chore: add remote client server disconnect
RobinBol Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
name: Build & Deploy to NPM

# Only run this job if initiator is not the Homey Github Actions Bot to prevent loops
if: github.actor != 'HomeyGithubActionsBot' && github.ref == 'refs/heads/production'
if: github.actor != 'homey-bot' && github.ref == 'refs/heads/production'

runs-on: ubuntu-latest
steps:
Expand Down
12 changes: 12 additions & 0 deletions remote/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,18 @@ class DeviceHandleProxy extends Duplex {
static get constants() {
return CONSTANTS;
}

/**
* Disconnect the remote socket.io connection.
* Call this when done using all device handles to allow the process to exit.
*/
static async disconnect() {
if (server) {
const serv = await server;
serv.disconnect();
server = null;
}
}
}

DeviceHandleProxy.prototype.__init = makeRemoteFunc('create_handle');
Expand Down