This repository was archived by the owner on Dec 15, 2022. It is now read-only.
⬆️ atom engine > 1.30.0 #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In Atom 1.30.0, a new api was added to Atom to
observeRepositoriesfor a project. That api is used in themetricspackage. Unit tests were written for themetricspackage that depend on this new api being in place. This pull request removes an if check in those unit tests so that the tests actually run, and upgrades the atom engine field inpackage.jsonto indicate that > 1.30.0 version is required.Alternate Designs
n/a
Benefits
The unit tests will actually run and guard against future regressions.
Possible Drawbacks
Can't think of any.
Applicable Issues
n/a