-
Notifications
You must be signed in to change notification settings - Fork 1
feature: support for Google Assistant API v1alpha2 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey @WMisiedjan ! Looks good 👍 I went over the changes and I don't see anything that caught my attention. I'll test it in the next couple of days to make sure that it works on my end. Btw. Did you do something to fix the gRPC Unavailable errors? I couldn't see anything to handle them, so my best guess is that Google improved the reliability of the service with v1alpha2. |
… in other packages.
|
@awernick I noticed that I get grpc service unavailable error's mostly when my input audio wasn't converted properly to match the prefered format of Google. I build a function here which converts the audio to 16000hz PCM, this might be a good thing to have within the library itself; |
|
@WMisiedjan Awesome! I haven't gotten around to merging your changes. From what I see everything seems great, but I just need to test it on my end before I merge it. I'll definitely do this in the next couple of days. |
This solved many of the issues that I've had with this and other libraries, I have a working Electron Google Assistant client now that runs on this version, I'll release that client here on github this week.