fix: remove attached error listeners when ending connections #600
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophia-bq
approved these changes
Jan 8, 2026
| this.properties, | ||
| "end", | ||
| () => { | ||
| this.pluginService.removeErrorListener(this.targetClient); |
Contributor
There was a problem hiding this comment.
The actual method of removeErrorListener only removes the trackingListener - would it be cleaner to remove the noOpListener as well?
Contributor
Author
There was a problem hiding this comment.
noOp listeners are only attached during the execution pipeline, so they should already be removed at the end of the application. end() may be called during the execution pipeline (PluginManager#execute()), so I want to avoid accidentally removing the listeners during the workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PG client was not properly removing attached error listeners when releasing connections.
This PR ensures listeners are removed before ending connections.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.