This repository was archived by the owner on Apr 22, 2025. It is now read-only.
fix: also pass --no-notices to cdk diff
#66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `options` field was being respected by `fixture.deploy` and `fixture.destory`, but not `fixture.cdk`.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
approved these changes
Mar 18, 2025
iankhou
approved these changes
Mar 18, 2025
auto-merge was automatically disabled
March 18, 2025 15:08
Pull request was closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
optionsfield was being respected byfixture.deployandfixture.destory, but notfixture.cdk.Necessary to make aws/aws-cdk-cli#221 pass.