This repository was archived by the owner on Apr 22, 2025. It is now read-only.
fix: not require aws-cdk to be a default dependency of amplify #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
approved these changes
Mar 26, 2025
rix0rrr
approved these changes
Mar 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aws-amplify/amplify-backend#2614 Amplify is proposing to remove the app dependency on
aws-cdkin favor of the new integration with@aws-cdk/toolkit-lib.This would cause our tests to fail, since we expected
aws-cdkto be listed in thedefault_packages.jsonfile. With this fix, we allow the dep to be there or not.