This repository was archived by the owner on Apr 22, 2025. It is now read-only.
fix(cli-integ): some tests are failing when executing the suite with atmosphere #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
changed the title
iliapolo
commented
Apr 3, 2025
| // subprocess expects a user input now. | ||
| // we have to write the input AFTER the child has started | ||
| // reading, so we do this with a small delay. | ||
| setTimeout(() => { |
Contributor
Author
There was a problem hiding this comment.
Unrelated to atmosphere but i've seen sporadic behavior with interactive tests as well, this seems to have resolved it.
iliapolo
commented
Apr 3, 2025
| await shell.shell(['npx', 'ampx', 'sandbox', '--once'], { | ||
| modEnv: { | ||
| AWS_REGION: context.aws.region, | ||
| ...awsCreds |
Contributor
Author
There was a problem hiding this comment.
This was just missing because this test is in a different suite, which I wasn't testing against.
iliapolo
changed the title
mrgrain
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline code comments provide the necessary justifications. Also in this PR: Actually enable atmosphere so subsequent (not this one) PRs start using it.
Draft until we get atmosphere prod fully launched with enough environments